Corridor outline #1099
Corridor outline #1099
Conversation
Conflicts: Source/Core/CorridorGeometry.js
| @@ -81,7 +81,7 @@ var geometry = BoxGeometry.createGeometry(box); | |||
| * Fixed triangulation for polygons that cross the international date line. | |||
| * Fixed `EllipsoidPrimitive` rendering for some oblate ellipsoids. [#1067](https://github.com/AnalyticalGraphicsInc/cesium/pull/1067). | |||
| * Upgraded Knockout from version 2.2.1 to 2.3.0. | |||
| * Added `CorridorGeometry`. | |||
| * Added `CorridorGeometry` and `CorridorGeometryOutline. | |||
There was a problem hiding this comment.
That's alright, I'm just being optimistic.
There was a problem hiding this comment.
The end tick after CorridorGeometryOutline is missing.
Conflicts: CHANGES.md
| var originScratch = new Cartesian3(); | ||
| var nextScratch = new Cartesian3(); | ||
| var prevScratch = new Cartesian3(); | ||
| CorridorGeometryLibrary.angleIsGreaterThanPi = function(forward, backward, position, ellipsoid) { |
There was a problem hiding this comment.
You should add @private doc to all functions that can be accessed from CorridorGeometryLibrary.
|
@hpinkos Those are the only comments I have. They are mostly formatting and doc changes so you can probably get this into b20. Let me know when its ready for another review. |
|
@hpinkos don't try to fit this into b20. The timing will make it too stressful. b21 is perfectly fine for this. |
|
Extrusions look wrong. var corridorOutline = new Cesium.GeometryInstance({
geometry: new Cesium.CorridorOutlineGeometry( {
positions: positions,
width: width,
height: 700000,
extrudedHeight: 100000
}),
attributes: {
color : solidWhite
}
}); |
|
It wasn't added in this pull request, but |
|
@bagnell somewhat unrelated to this pull request, but we should think about how we can pipe outline geometries into your upcoming polyline geometry and appearances so the outlines can have all the styling of the current PolylineCollection. It should be pretty easy. |
|
@bagnell this is ready for review again |
No description provided.