Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor performance improvements #1079

Merged
merged 3 commits into from
Aug 26, 2013
Merged

Minor performance improvements #1079

merged 3 commits into from
Aug 26, 2013

Conversation

pjcozzi
Copy link
Contributor

@pjcozzi pjcozzi commented Aug 26, 2013

This is a minor change as I start to improve commands for models.

For the default view in the terrain Sandcastle example, the hotspot was creating the depth plane's typed array at 0.34% and the garbage collector also at 0.34%. This eliminates the typed array creation from the profile and drops the garbage collector to 0.18%.

@kring
Copy link
Member

kring commented Aug 26, 2013

Were you able to get Web Mercator terrain to work in order to test the pole filling? I get an exception when I try.
image
Introduced with the geometry batching stuff? Or maybe it's been broken longer than that...

@mramato
Copy link
Contributor

mramato commented Aug 26, 2013

This worked recently, so I bet it broke with Geometry WebWorkers.

@mramato
Copy link
Contributor

mramato commented Aug 26, 2013

Okay, I just checked master and it works there.

@kring
Copy link
Member

kring commented Aug 26, 2013

How did you test it? I hacked EllipsoidTerrainProvider to use WebMercatorTilingScheme instead of GeographicTilingScheme. I'll try in master, though it's not clear how Cozzi's changes would cause what I'm seeing.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Aug 26, 2013

Were you able to get Web Mercator terrain to work in order to test the pole filling?

I didn't get any love when I tried.

@kring
Copy link
Member

kring commented Aug 26, 2013

It doesn't work in master for me. @pjcozzi did you get the same problem?

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Aug 26, 2013

How did you test it? I hacked EllipsoidTerrainProvider to use WebMercatorTilingScheme instead of GeographicTilingScheme.

I tried this too, but I didn't get a globe at all, and it didn't hit the breakpoints in my new code.

Shame on me, I know.

@kring
Copy link
Member

kring commented Aug 26, 2013

Ok well this pull request looks fine. Pole filling is totally broken, but that's a separate problem. I'll write an issue for it.

kring added a commit that referenced this pull request Aug 26, 2013
@kring kring merged commit 2a72fb7 into master Aug 26, 2013
@kring kring deleted the depthQuadTypedArray branch August 26, 2013 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants