-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor performance improvements #1079
Conversation
This worked recently, so I bet it broke with Geometry WebWorkers. |
Okay, I just checked master and it works there. |
How did you test it? I hacked |
I didn't get any love when I tried. |
It doesn't work in master for me. @pjcozzi did you get the same problem? |
I tried this too, but I didn't get a globe at all, and it didn't hit the breakpoints in my new code. Shame on me, I know. |
Ok well this pull request looks fine. Pole filling is totally broken, but that's a separate problem. I'll write an issue for it. |
This is a minor change as I start to improve commands for models.
For the default view in the terrain Sandcastle example, the hotspot was creating the depth plane's typed array at 0.34% and the garbage collector also at 0.34%. This eliminates the typed array creation from the profile and drops the garbage collector to 0.18%.