Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't wait for the container to start building if new-app didn't retu… #88

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Don't wait for the container to start building if new-app didn't retu… #88

merged 1 commit into from
Sep 24, 2018

Conversation

dirgim
Copy link
Contributor

@dirgim dirgim commented Sep 20, 2018

Don't wait for the container to start building if the new-app command didn't return anything.

@dirgim
Copy link
Contributor Author

dirgim commented Sep 20, 2018

[test]

arilivigni
arilivigni approved these changes Sep 20, 2018
View reviewed changes
Copy link
Member

@arilivigni arilivigni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

playbooks/roles/os_temps/tasks/build_new_app.yml Show resolved Hide resolved
@arilivigni arilivigni merged commit 32d9b29 into CentOS-PaaS-SIG:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skatlapa skatlapa skatlapa left review comments

@arilivigni arilivigni arilivigni approved these changes

@joejstuart joejstuart Awaiting requested review from joejstuart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirgim @arilivigni @skatlapa