No need to restart the VM if the config was not updated #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me - I would just add that this change enables usage of the 1st case (both setup_minishift and start_minishift set to true), and only in that case is the minishift stop skipped - meaning that this doesn't affect running the contra-env-setup with the default options (the 2nd case), except for the better check for the host-passthrough option. |
werne2j
reviewed
Sep 6, 2018
|
|
||
| - name: Wait for the cluster to come up completely | ||
| - name: "Check if <cpu mode=host-passthrough/> is already set" |
There was a problem hiding this comment.
Would it be better to put these tasks in a block that only has the 1 linux check vs having that check 4 separate times?
There was a problem hiding this comment.
Yes, that sounds reasonable. Will fix it.
In order to apply the cpu mode="host-passthrough" config to the VM, one needs
to stop the VM first. That was the case before, every time. However, at
least on Fedora, the cpu mode="host-passthrough" is configured by
default and thus there is no need to actually update the config and then
restart the VM. This considerably speeds up the the process.
Note about the setup_minishift and start_minishift flag values - there
are four possible cases:
1) 'setup_minishift == true and start_minishift == true' --- this will
result in creating and initializing brand new minishift profile, which
will be running after the init is done.
2) 'setup_minishift == true and start_minishift == false' --- this will
result in creating and initializing brand new minishift profile,
but it will be stopped at the end (as start_minishift == false).
It may well be started again by e.g. the os_temps role which
usually comes after the minishift role.
3) 'setup_minishift == false and start_minishift == true' --- this
won't initialize (create) the VM at all. The VM is expected to be
created before running contra-env-setup. The VM will, however, be
started at the end (in case it's not already running).
4) 'setup_minishift == false and start_minishift == false' --- this
won't do minishift operations at all. This combination is useful
for deploying into remote OpenShift clusters.
psiroky
force-pushed
the
check-cpu-mode
branch
from
118bca7 to
38e9528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to apply the cpu mode="host-passthrough" config to the VM, one needs
to stop the VM first. That was the case before, every time. However, at
least on Fedora, the cpu mode="host-passthrough" is configured by
default and thus there is no need to actually update the config and then
restart the VM. This considerably speeds up the the process.
Note about the setup_minishift and start_minishift flag values - there
are four possible cases:
'setup_minishift == true and start_minishift == true' --- this will
result in creating and initializing brand new minishift profile, which
will be running after the init is done.
'setup_minishift == true and start_minishift == false' --- this will
result in creating and initializing brand new minishift profile,
but it will be stopped at the end (as start_minishift == false).
It may well be started again by e.g. the os_temps role which
usually comes after the minishift role.
'setup_minishift == false and start_minishift == true' --- this
won't initialize (create) the VM at all. The VM is expected to be
created before running contra-env-setup. The VM will, however, be
started at the end (in case it's not already running).
'setup_minishift == false and start_minishift == false' --- this
won't do minishift operations at all. This combination is useful
for deploying into remote OpenShift clusters.