Allow to use minishift > v1.13.0 #53

lslebodn · 2018-06-19T13:52:46Z

minishift v.1.13.0 change storage driver for docker from device mapper
to overlay2. And therefore it hit a bug with wrong SELinux label of files
in /var/lib/docker

This is a workaround for images which does not have the fix
minishift/minishift-centos-iso#216
minishift/minishift-centos-iso#217

arilivigni

Shouldn't we also increase the defaults:
dkvm_version: v0.7.0
minishift_version: v1.12.0

lslebodn · 2018-06-19T14:02:08Z

Shouldn't we also increase the defaults:
dkvm_version: v0.7.0
minishift_version: v1.12.0

I can bump versions

We would need to use v1.17.0 due to issue with oc login -u system:admin minishift/minishift#2107

I will test never version of dkvm_version

minishift v.1.13.0 change storage driver for docker from device mapper to overlay2. And therefore it hit a bug with wrong SELinux label of files in /var/lib/docker This is a workaround for images which does not have a fix minishift/minishift-centos-iso#216 minishift/minishift-centos-iso#217 This commit might be reverted after some time when standard/default images would contain correct SELinux labeling.

It was released on on Apr 17, 2017

Never versions of minishift have some bugfixes + new features. ATM, latest version is v1.18.0 but there is and issue with login to minishift as system:admin. minishift/minishift#2107 There might be workarounds with using custom addons but it would break assumptions in existing pipelines

minishift v1.12.0 and v1.13.0 did not support options configuration options skip-check-openshift-version and skip-check-openshift-release Drop these check after increasing default version of minishift (it might be complicated to support such old versions in future)

lslebodn · 2018-06-19T15:19:43Z

I tested with CVP pipeline + overriden minishift version (v1.14.0, v1.15.0, v1.16.0, v1.17.0, v1.18.0)
Passed for me. I hope changes would not break other pipelines :-)

arilivigni · 2018-06-19T15:23:10Z

README.md

@@ -79,7 +79,7 @@ contra-env-setup/playbooks/group_vars/all/global.yml

 ### Minishift setup options
 * setup_minishift: Setup a minishift cluster : default=true
-* minishift_version: Minishift version to use : default=v1.12.0
+* minishift_version: Minishift version to use : default=v1.17.0


We can't support this as the default until we update the Custom CentOS ISO or we need to change the default CentOS ISO from minishift. I vote for the former since that will break others.

I believe it should work, because the MR also contains the Workaround for wrong SELinux context (which was the issue with newer versions of minishift). If we upgrade the CentOS image, then this workaround should no longer be needed.

yes, that's main purpose of the 1st patch.
Allow to use v.1.17 with current default ISO.

The commit message even say that it can be reverted later when default ISO have right SELinux labeling

arilivigni · 2018-06-19T15:23:32Z

playbooks/group_vars/all/global.yml

@@ -16,11 +16,11 @@ force_repo_clone: true
 contra_env_setup_dir: "{{ ansible_env.HOME }}/.contra-env-setup"

 # Docker KVM version
-dkvm_version: v0.7.0
+dkvm_version: v0.10.0


Will this driver work with 1.12.0 of minishift?

I will need to test with 1.12.0 but then we will need to drop the patch if we want to still support v1.12.0

fc29ab2

Bumping v0.10.0 is not enough because since 0.10.0 docker-machine-driver-kvm does not exist.
There are more versions with "distribution suffix" after name
e.g. docker-machine-driver-kvm-{centos7,alpine3.4,alpine3.5,ubuntu14.04,ubuntu16.04}

Previously it passed for me because I already had /usr/local/bin/docker-machine-driver-kvm on testing machines

arilivigni · 2018-06-19T15:23:40Z

playbooks/group_vars/all/global.yml


 ## minishift values
 # minishift version
-minishift_version: v1.12.0
+minishift_version: v1.17.0


We can't support this as the default until we update the Custom CentOS ISO or we need to change the default CentOS ISO from minishift. I vote for the former since that will break others.

arilivigni · 2018-06-19T15:37:03Z

@lslebodn this is blocked then until I update the custom CentOS ISO since that will affect others. At the moment I think you can override all values and run the setup anyways correct?

psiroky · 2018-06-19T15:48:49Z

Yes, AFAIK, this is not blocking us. We can override both the minishift version and the centos image URL.

arilivigni · 2018-06-19T15:50:17Z

@psiroky @lslebodn excellent I am working on the updates based on the minishift CentOS ISO. Once I have it in place I may ask you guys run it through some testing.

lslebodn · 2018-06-19T21:27:09Z

@arilivigni,
BTW if you prefer support v,1,12 I am fine with removing the patch "Drop support for older versions of minishift". But I would need to test dkvm version as you requested.

Just let me know :-)

arilivigni · 2018-06-19T21:29:14Z

@lslebodn instead of the newer driver can you test the iso I sent to you in a separate email thread. I want to see if this works then we can move the defaults ahead which would be great.

Thoughts?

scoheb · 2018-06-19T22:26:05Z

I can take a stab at it tonight and report back..

scoheb · 2018-06-20T01:28:27Z

so with both your new iso version @arilivigni and the version @psiroky put in his MR, I get the error that the first Jenkins deployment fails with:

error: update acceptor rejected jenkins-1: watch closed before Until timeout
--> Error listing events for replication controller jenkins-1: Get https://172.30.0.1:443/api/v1/namespaces/cvp/events?fieldSelector=involvedObject.namespace%3Dcvp%2CinvolvedObject.kind%3DReplicationController%2CinvolvedObject.uid%3Db0dda34e-7427-11e8-bdac-52540041768f%2CinvolvedObject.name%3Djenkins-1: dial tcp 172.30.0.1:443: getsockopt: connection refused

but a second manual re-deploy works.

I am using minishift_version: v1.17.0

arilivigni · 2018-06-20T02:20:31Z

@scoheb What branch of our private project did you use. I am using master. It worked for me the first time and than failed somewhere different for me.

Also did you use v1.17.0 with the the general minishift iso https://github.com/minishift/minishift-centos-iso/releases/download/v1.10.0/minishift-centos7.iso?

arilivigni · 2018-06-20T05:14:12Z

@scoheb worked for me with the sample project not the project_repo we care about more.

psiroky · 2018-06-20T11:39:54Z

I am getting the same error as Scott:

error: update acceptor rejected jenkins-1: watch closed before Until timeout
--> Error listing events for replication controller jenkins-1: Get https://172.30.0.1:443/api/v1/namespaces/cvp/events?fieldSelector=involvedObject.namespace%3Dcvp%2CinvolvedObject.kind%3DReplicationController%2CinvolvedObject.uid%3Db0dda34e-7427-11e8-bdac-52540041768f%2CinvolvedObject.name%3Djenkins-1: dial tcp 172.30.0.1:443: getsockopt: connection refused

Looking into it now.

arilivigni · 2018-06-20T18:57:59Z

@lslebodn can this PR be closed now?

alexellis · 2018-06-21T15:32:13Z

I'm hitting this issue, please could you give a work-around? Is there a minishift binary I can download to to make this work?

arilivigni · 2018-06-21T15:37:26Z

override the defaults:
minishift_version: v1.17.0
minishift_iso: https://github.com/minishift/minishift-centos-iso/releases/download/v1.10.0/minishift-centos7.iso

I also am working on another PR for an updated CentOS Image with libvirt

alexellis · 2018-06-21T16:05:48Z

I'm not sure where I should put those versions.. are you referring to a config file or a CLI flag to minishift? I just type in minishift start

arilivigni · 2018-06-21T18:56:14Z

@alexellis the options on the command line -e minishift_version=v1.17.0 or in a file that you pass either way standard ansible passing of values

arilivigni · 2018-06-21T19:01:22Z

@alexellis this PR should explain things better #57

arilivigni · 2018-06-25T02:39:27Z

@alexellis v1.1.17 should address this now completely

alexellis · 2018-06-25T05:49:59Z

@arilivigni thanks for following up, that sounds great. I'll give it a shot.

alexellis · 2018-06-25T05:51:17Z

What's the best way to update to this minishift start -e minishift_version=v1.1.17?

I get this error using the suggested env-var flag for minikube start: unknown shorthand flag: 'e' in -e`

I don't think I'm typing this in right, but don't know how to configure it either.

The only flag I can seem to override is --iso-url=

Downgraded CLI manually on my Mac:

minishift v1.17.0+f974f0c

Set override URL:

minishift start --vm-driver=virtualbox --cpus=4 --memory=4GB --iso-url=minishift version ; minishift start --vm-driver=virtualbox --cpus=4 --memory=4GB --iso-url=https://s3.amazonaws.com/continuous-infra/minishift/iso/minishift.iso

Will let you know how this goes.

arilivigni · 2018-06-25T13:36:10Z

These are values passed to the contra-env-setup not the minishift command. Maybe you just want to use minishift directly for what you want to do.

arilivigni reviewed Jun 19, 2018

View reviewed changes

lslebodn force-pushed the docker_selinux_workaround branch from 6999ddc to d148a27 Compare June 19, 2018 13:57

Lukas Slebodnik added 4 commits June 19, 2018 17:14

Bump to latest release of docker-machine-kvm

319adba

It was released on on Apr 17, 2017

lslebodn force-pushed the docker_selinux_workaround branch from d148a27 to fc29ab2 Compare June 19, 2018 15:16

lslebodn changed the title ~~Allow to use minishift >= v1.13.0~~ Allow to use minishift > v1.13.0 Jun 19, 2018

arilivigni reviewed Jun 19, 2018

View reviewed changes

arilivigni closed this Jun 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow to use minishift > v1.13.0 #53

Allow to use minishift > v1.13.0 #53

lslebodn commented Jun 19, 2018

arilivigni left a comment

lslebodn commented Jun 19, 2018

lslebodn commented Jun 19, 2018

arilivigni Jun 19, 2018

psiroky Jun 19, 2018

lslebodn Jun 19, 2018

arilivigni Jun 19, 2018

lslebodn Jun 19, 2018

lslebodn Jun 20, 2018

arilivigni Jun 19, 2018

arilivigni commented Jun 19, 2018

psiroky commented Jun 19, 2018

arilivigni commented Jun 19, 2018

lslebodn commented Jun 19, 2018

arilivigni commented Jun 19, 2018

scoheb commented Jun 19, 2018

scoheb commented Jun 20, 2018

arilivigni commented Jun 20, 2018

arilivigni commented Jun 20, 2018

psiroky commented Jun 20, 2018

arilivigni commented Jun 20, 2018

alexellis commented Jun 21, 2018

arilivigni commented Jun 21, 2018

alexellis commented Jun 21, 2018

arilivigni commented Jun 21, 2018

arilivigni commented Jun 21, 2018

arilivigni commented Jun 25, 2018

alexellis commented Jun 25, 2018

alexellis commented Jun 25, 2018 •

edited

Loading

arilivigni commented Jun 25, 2018

Allow to use minishift > v1.13.0 #53

Allow to use minishift > v1.13.0 #53

Conversation

lslebodn commented Jun 19, 2018

arilivigni left a comment

Choose a reason for hiding this comment

lslebodn commented Jun 19, 2018

lslebodn commented Jun 19, 2018

arilivigni Jun 19, 2018

Choose a reason for hiding this comment

psiroky Jun 19, 2018

Choose a reason for hiding this comment

lslebodn Jun 19, 2018

Choose a reason for hiding this comment

arilivigni Jun 19, 2018

Choose a reason for hiding this comment

lslebodn Jun 19, 2018

Choose a reason for hiding this comment

lslebodn Jun 20, 2018

Choose a reason for hiding this comment

arilivigni Jun 19, 2018

Choose a reason for hiding this comment

arilivigni commented Jun 19, 2018

psiroky commented Jun 19, 2018

arilivigni commented Jun 19, 2018

lslebodn commented Jun 19, 2018

arilivigni commented Jun 19, 2018

scoheb commented Jun 19, 2018

scoheb commented Jun 20, 2018

arilivigni commented Jun 20, 2018

arilivigni commented Jun 20, 2018

psiroky commented Jun 20, 2018

arilivigni commented Jun 20, 2018

alexellis commented Jun 21, 2018

arilivigni commented Jun 21, 2018

alexellis commented Jun 21, 2018

arilivigni commented Jun 21, 2018

arilivigni commented Jun 21, 2018

arilivigni commented Jun 25, 2018

alexellis commented Jun 25, 2018

alexellis commented Jun 25, 2018 • edited Loading

arilivigni commented Jun 25, 2018

alexellis commented Jun 25, 2018 •

edited

Loading