Allow to set insecure registry with minishift #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should work but I'll test with our pipeline and then add comment here. |
|
LGTM. |
psiroky
reviewed
Jun 18, 2018
| @@ -86,6 +86,7 @@ contra-env-setup/playbooks/group_vars/all/global.yml | |||
| * memory: Memory size to use for the VM : default=6400mb | |||
| * cpus: Number of cpus to use for minishift VM: default=2 | |||
| * minishift_iso: ISO image to use : default=http://artifacts.ci.centos.org/fedora-atomic/minishift/iso/minishift.iso | |||
| * minishift_insecure_registry: Additional insecure registries : default="" (not used) | |||
There was a problem hiding this comment.
Should we call this minishift_insecure_registries since it can contain multiple registries?
There was a problem hiding this comment.
I'm fine even with minishift_insecure_registries I used singular because of singular in minishift config.
minishift config set insecure-registry
There was a problem hiding this comment.
OK, I wasn't aware of that. Let's keep the singular then.
scoheb
reviewed
Jun 18, 2018
| @@ -28,6 +28,10 @@ | |||
| - name: "Set minishift openshift-version to {{ oc_version }}" | |||
| shell: "{{ minishift_bin }} config set openshift-version {{ oc_version }}" | |||
|
|
|||
| - name: "Set minishift minishift_insecure_registry" | |||
| shell: "{{ minishift_bin }} config set insecure-registry \"{{ minishift_insecure_registry }}\"" | |||
There was a problem hiding this comment.
yes
[root@host~]# minishift config view
- cpus : 2
- disk-size : 40gb
- memory : 6400mb
- openshift-version : v3.9.0
- skip-check-openshift-release : true
- skip-check-openshift-version : true
[root@host ~]# minishift config set insecure-registry registry1.example.com
[root@host ~]# minishift config view
- cpus : 2
- disk-size : 40gb
- insecure-registry : [registry1.example.com]
- memory : 6400mb
- openshift-version : v3.9.0
- skip-check-openshift-release : true
- skip-check-openshift-version : true
[root@host ~]# minishift config set insecure-registry registry1.example.com,registry2.example.com
[root@host ~]# minishift config view
- cpus : 2
- disk-size : 40gb
- insecure-registry : [registry1.example.com registry2.example.com]
- memory : 6400mb
- openshift-version : v3.9.0
- skip-check-openshift-release : true
- skip-check-openshift-version : true
There was a problem hiding this comment.
I think names should match to what minishift uses so should be singular IMHO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.