Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix bug: When saving a file in Linux, the file name extension is not …" #405

Merged
merged 1 commit into from
May 29, 2024

Conversation

tishion
Copy link
Member

@tishion tishion commented May 29, 2024

Reverts #402

@tishion
Copy link
Member Author

tishion commented May 29, 2024

Hey @mogoweb, after further reviewing and testing this PR, we need to revert it now. because it breaks the compatibility between QCefView and different Qt versions.

@L-Super Please help to review.

@tishion tishion enabled auto-merge (rebase) May 29, 2024 14:10
Copy link
Member

@L-Super L-Super left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tishion tishion merged commit 7e6f5f0 into main May 29, 2024
3 checks passed
@tishion tishion deleted the revert-402-main branch May 30, 2024 03:29
@mogoweb
Copy link
Contributor

mogoweb commented May 30, 2024

Hey @mogoweb, after further reviewing and testing this PR, we need to revert it now. because it breaks the compatibility between QCefView and different Qt versions.

@L-Super Please help to review.

Sorry, I only tested this on Qt 5.15.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants