-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ReactPickerView): Add ReactPickerView #265
Conversation
Basic functionality works - labels, colors, value change, style `<View
` ... |
@@ -13,8 +13,9 @@ | |||
'use strict'; | |||
|
|||
var ColorPropType = require('ColorPropType'); | |||
var PickerIOS = require('PickerIOS'); | |||
var PickerAndroid = require('PickerAndroid'); | |||
//var PickerIOS = require('PickerIOS'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to keep everything working on iOS and Android, I don't think we can comment these out.
ReactPicker provides access to native selector UI Components for React Native JavaScript applications. Selector is implemented as ComboBox. Fixes #231
ReactPicker provides access to native selector UI components for React Native JavaScript applications. - PR comments implemented Fixes #231
* | ||
* @providesModule PickerIOS | ||
*/ | ||
'use strict'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to name this file PickerIOS.windows.js #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also make sure this outputs an "UnimplementedView", i.e.:
module.exports = require('UnimplementedView');
In reply to: 56820832 [](ancestors = 56820832)
// surrounding view to ensure it gets rendered. | ||
// TODO would be better to export a native constant for this, | ||
// like in iOS the RCTDatePickerManager.m | ||
height: 40, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this constant, since it has custom measurement? #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
👍 |
…edView ReactPicker provides access to native selector UI components for React Native JavaScript applications. Fixes #231
feat(ReactPickerView): Add ReactPickerView
ReactPicker provides access to native selector UI Components for React Native JavaScript applications.
Fixes #231