-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: AMCP Command UID #475
Comments
…y command to identify the response with a client specified request id, allowing a client to know exactly what asynchronous response matched a specific request.
It is building now. |
W.O.W !! This is the greatest news in a while! Thank you so much! |
It works so well. Cool! |
Yeah ! So cool ! |
…efore any command to identify the response with a client specified request id, allowing a client to know exactly what asynchronous response matched a specific request. Former-commit-id: d896f42
…efore any command to identify the response with a client specified request id, allowing a client to know exactly what asynchronous response matched a specific request. Former-commit-id: d896f42 Former-commit-id: 37204ebd98b515805d99ddddd0192d5f0e14b5d1 [formerly 46d3689] Former-commit-id: 2f550b38851d05a03b07a0a161b2381a3e9e2b3d
…efore any command to identify the response with a client specified request id, allowing a client to know exactly what asynchronous response matched a specific request. Former-commit-id: d896f42 Former-commit-id: 37204ebd98b515805d99ddddd0192d5f0e14b5d1 [formerly 46d3689] Former-commit-id: 2f550b38851d05a03b07a0a161b2381a3e9e2b3d Former-commit-id: 1b8b9c4108cd827533dc69e78661b54e4277c78a [formerly 78f0a09] Former-commit-id: 06d4ddf1861168050514a8b065562ca88f6378c8
…y command to identify the response with a client specified request id, allowing a client to know exactly what asynchronous response matched a specific request.
…y command to identify the response with a client specified request id, allowing a client to know exactly what asynchronous response matched a specific request. Former-commit-id: 43f3400
Current implementation of the REQ command only focuses on just the instant response from the server. I think there should be a corresponding RES command that can be use to later query a layer for the UID. |
Hi @PeterAkakpo. If I understand you correctly you want to be able to read out state from the server. I don't think your approach to calculate state by evaluating command responses will work for a couple of reasons:
What you want to do is currently best done over OSC, and it seems like INFO will be added back to 2.2/2.3, and that's also a nice and simple approach. |
If you send multiple commands at once, you need a way of identifying responses to match against the commands being sent. AMCP is not synchronous in its responses.
We need to maintain backwards compatibility in adding a new optional parameter to each command. We could either add new UID to the end of each command, given that the format of this UID is distinguishable and can not be mistaken for another payload parameter at all. Or, we could optionally add a prefix value before each command, i.e:
REQ sdfkjxcvxcv PLAY 1-10
RES sdfkjxcvxcv 202 PLAY OK
The text was updated successfully, but these errors were encountered: