-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sc 377004/add raster loader support for snowflake #127
Feature/sc 377004/add raster loader support for snowflake #127
Conversation
This pull request has been linked to Shortcut Story #377004: Add raster-loader support for Snowflake. |
I'm struggling still to achieve loading a raster into snowflake. When executing the upload command I receive a crash because of the snowflake python connector not being installed. *UPDATE: I've tried removing my previous builds and so on and it seems that even keeping the name snowflake.py the installation is detected. Also got the next error when deleting a partially uploaded table:
So we might have to set the database as default when uploading the table. *Finally managed to upload a raster it required setting a default DATABASE and SCHEMA in the client constructor. |
I've just noticed that in the ticket the parameter --role was included:
It would be nice to include it as it will define who is the owner of the table in snowflake once created. |
I've done some changes since I've discovered that the chunks are getting constantly overwritten. That's why I was getting too small table results during the QA.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice LGTM.
Just notice I've done some updates in the code to not overwrite chunks.
Also as I was having when appending multiple rasters with nodata=NaN. I've explicitely updated this value to null, as I saw in a previously updated table cartodb-data-engineering-team.jarroyo.usa_pop_raster
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's release |
Proposed Changes
This PR adds support for Snowflake
A refactoring of the main scripts has also been made, to leave a cleaner and more extensible code, which allows to reuse code between platforms.