Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: amarna #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

milancermak
Copy link
Contributor

This PR adds Amarna, a static code analyzer, to the CI.

At times, it has false positives, but generally it's pretty helpful. For example, it detected an unused import of ACCOUNT_BALANCE_UPPER_BOUND in amm.cairo - but shouldn't it be used in set_account_balance on line 89 instead of POOL_BALANCE_UPPER_BOUND?

Anyway, I hope it'll actually work and run the first time, GitHub Actions can be a bit finicky to set up :)

tensojka added a commit that referenced this pull request Aug 8, 2022
@tensojka
Copy link
Contributor

tensojka commented Aug 8, 2022

This works pretty nicely, but for the moment would IMO be a distraction, since the code is a mess and we know it. For the moment, I added a very simple runner that simply checks whether the code can be built or not (see protostar.yml in master) and I'd merge this once LP tokens and option tokens are done and we are free for some cleanup work.

@MarekHauzr
Copy link
Member

This works pretty nicely, but for the moment would IMO be a distraction, since the code is a mess and we know it. For the moment, I added a very simple runner that simply checks whether the code can be built or not (see protostar.yml in master) and I'd merge this once LP tokens and option tokens are done and we are free for some cleanup work.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants