Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

Commit

Permalink
feat: minor optimizations
Browse files Browse the repository at this point in the history
  • Loading branch information
mobo4b committed Nov 24, 2020
1 parent cb8e287 commit 4bdbe22
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@
import org.springframework.stereotype.Service;

/**
* Service class to handle diocese admin requests
* Service class to handle diocese admin requests.
*/

@Service
@RequiredArgsConstructor
public class DioceseAdminService {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
/**
* Diocese entity.
*/

@Entity
@Table(name = "diocese")
@AllArgsConstructor
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,11 @@ public void getDioceses_Should_returnOk_When_requiredPaginationParamsAreGiven()
.findAllDioceses(eq(0), eq(1));
}

@Test
public void getDioceses_Should_returnBadRequest_When_requiredPaginationParamsAreMissing()
throws Exception {
this.mvc.perform(get(GET_DIOCESES_PATH))
.andExpect(status().isBadRequest());
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public void buildPaginationLinks_ShouldNot_haveNextLink_When_currentPageIsTheLas
}

@Test
public void buildPaginationLinks_Should_returnPlaceHolderSelfLink_When_keywordIsNotSet() {
public void buildPaginationLinks_Should_returnSelfLink() {
PaginationLinks paginationLinks = DiocesePaginationLinkBuilder.getInstance()
.withPage(1)
.withPerPage(20)
Expand Down

0 comments on commit 4bdbe22

Please sign in to comment.