A0-4073: Add a basic circuit runner #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroist
reviewed
Feb 26, 2024
| }; | ||
|
|
||
| let instance = vec![Fr::from_u128(4)]; | ||
| run(&cg, input.clone(), instance, k_circuit, k_srs); |
There was a problem hiding this comment.
no need to input.clone(), pass as input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a crate
circuit_runnerthat allows to run the full pipeline of keygen, prove, verify (or mock) for a circuit written in halo2-lib. The halo2-lib circuits can be run by implementing a simpleCircuitGeneratortrait. See thesquareexample for details. I tried to avoid thesnark-verifierdependency, but failed to do so. This is doable, but I moved this to a separate task.I also tried to make it more generic -- not hardcode BN256, this also seems possible, but requires some work (also not this PR).
The follow-up to this will be a new example (in
examples) with a circuit using the abstractions fromrelations.