Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stablepool deployment scripts #116

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Stablepool deployment scripts #116

merged 6 commits into from
Aug 30, 2024

Conversation

JanKuczma
Copy link
Contributor

Simple script for deploying Stablepool contract with example setup files.

@JanKuczma JanKuczma requested a review from deuszx August 23, 2024 09:00
deuszx
deuszx previously requested changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@deuszx deuszx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good but I think you've overcomplicated this a bit w/ the secrets.json and wallet.json setup.

Happy to be convinced otherwise.

.gitignore Outdated Show resolved Hide resolved
scripts/amm/stablepool/secrets.example.json Outdated Show resolved Hide resolved
scripts/amm/stablepool/README.md Outdated Show resolved Hide resolved
scripts/amm/stablepool/README.md Outdated Show resolved Hide resolved
scripts/amm/stablepool/deploy.ts Outdated Show resolved Hide resolved
scripts/amm/stablepool/deploymentPoolsParams.example.json Outdated Show resolved Hide resolved
@JanKuczma JanKuczma requested review from deuszx and woocash2 August 27, 2024 08:16
@deuszx deuszx dismissed their stale review August 30, 2024 09:49

Updated.

deuszx
deuszx approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@deuszx deuszx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I can't run it myself at the moment.

@JanKuczma JanKuczma merged commit 3923451 into main Aug 30, 2024
1 check passed
@JanKuczma JanKuczma deleted the stablepool-deployment-scripts branch August 30, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deuszx deuszx deuszx approved these changes

@krzysztofziobro krzysztofziobro krzysztofziobro approved these changes

@woocash2 woocash2 Awaiting requested review from woocash2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JanKuczma @krzysztofziobro @deuszx