Allow building with recent GHC, cardano-node, aeson #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ho that's a little embarrassing 😅 ... I was actually doing just that in the past few days and just pushed: abf409e |
|
No problem! Thanks! |
|
@sorki I am no longer using Haskell.nix though, so if you still want to add the sha256 digests for the custom deps, a PR is welcome 😶 |
Yeah, I'll submit a PR with that. I think that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--sha256hashes to make it buildable with haskell.nix againcardano-nodecardano-ledger-conwaybaseconstraintaeson 2.2, package got split intoattoparsec-aesonso we need to require that as well. If you don't like the lower bound, I can probably make the dependency conditional (not sure if possible with hpack).Ledger.Coininstead ofInteger