-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ tests refactoring #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
- add minter.feature - add yielder.feature - add gherkin context into yielder tests
- update yielder unit tests to match new format - add minter test initialization (which test views) - fix typo
Note: CI passed since it ran before the latest version of protostar, if we merge as it is the CI will fail after merge since protostar version hasn't been upgraded in this branch. I suggest to merge as it is then fix the CI with the next PR (fixing the protostar version). |
- create config file at each folder level - create a python file to mutualize hints code
update(config, yaml.safe_load(file_instance)) | ||
|
||
# set up context | ||
context = objectify(context, config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented the config proposition as expected.
Additionaly, I created a python file to capitalize code from cairo hints (especially in setup functions). Then objects got from config files are homogenous for all tests.
Note: Given the following use case:
(tests) - config.yml:
key:
some: text
(tests/folder) - config.yml:
key:
other: text
The loading will merge key contents instead of overriding those (which is more convenient), so we have the following config instantiated:
key:
some: text
other: text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect for me.
update(config, yaml.safe_load(file_instance)) | ||
|
||
# set up context | ||
context = objectify(context, config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect for me.
Fix #40