Feat: Revert to one-step minter #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudvenger
approved these changes
Jan 26, 2024
| let reserved_value = self._mint_reserved_value.read(); | ||
| let total_value = IProjectDispatcher { contract_address: project_address } | ||
| .total_value(slot); | ||
| total_value + reserved_value >= max_value |
There was a problem hiding this comment.
How can you have the total_value + reserved_valkue > to max_value ?
There was a problem hiding this comment.
Short answer: It shouldn't happen if there is only one correct minter.
It might happen with multiple minters, in that case we rely on the external view total_value and from the initializer requirements on project_value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #315