Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Two steps pay #246

Merged
merged 17 commits into from
Sep 25, 2023
Merged

✨ Two steps pay #246

merged 17 commits into from
Sep 25, 2023

Conversation

bal7hazar
Copy link
Contributor

No description provided.

@bal7hazar bal7hazar marked this pull request as ready for review September 20, 2023 13:58
@bal7hazar bal7hazar requested a review from tekkac September 20, 2023 13:58
Copy link
Member

@tekkac tekkac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

  • will need to sync for the Solidity part of the Minter.
  • would like to define specs for two-steps payments mints

src/components/mint/booking.cairo Show resolved Hide resolved
src/components/mint/module.cairo Outdated Show resolved Hide resolved
src/components/mint/module.cairo Show resolved Hide resolved
src/components/mint/module.cairo Outdated Show resolved Hide resolved
src/contracts/minter.cairo Show resolved Hide resolved
@bal7hazar bal7hazar requested a review from tekkac September 22, 2023 11:43
Copy link
Member

@tekkac tekkac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌

@bal7hazar bal7hazar merged commit 1fa913a into main Sep 25, 2023
@bal7hazar bal7hazar deleted the feat/two-steps-pay branch September 25, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants