Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

89 impl starkvest vestings #105

Merged
merged 9 commits into from
Dec 2, 2022
Merged

89 impl starkvest vestings #105

merged 9 commits into from
Dec 2, 2022

Conversation

cloudvenger
Copy link
Contributor

Fix #89

bal7hazar
bal7hazar suggested changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@bal7hazar bal7hazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you think about to update the documentation?
Because yielder and offseter become very different, we should consider to split farm feature into yield and offset in file structure and namespaces

src/farm/library.cairo Outdated Show resolved Hide resolved
src/farm/library.cairo Outdated Show resolved Hide resolved
src/farm/library.cairo Outdated Show resolved Hide resolved
tests/integrations/protocol/library.cairo Outdated Show resolved Hide resolved
tests/integrations/protocol/test_yielder.cairo Outdated Show resolved Hide resolved
tests/integrations/protocol/test_yielder.cairo Show resolved Hide resolved
src/farm/library.cairo Outdated Show resolved Hide resolved
tekkac
tekkac reviewed Dec 1, 2022
View reviewed changes
src/farm/library.cairo Outdated Show resolved Hide resolved
tekkac
tekkac requested changes Dec 1, 2022
View reviewed changes
src/farm/library.cairo Outdated Show resolved Hide resolved
src/farm/library.cairo Outdated Show resolved Hide resolved
src/farm/library.cairo Outdated Show resolved Hide resolved
src/farm/library.cairo Outdated Show resolved Hide resolved
src/farm/library.cairo Outdated Show resolved Hide resolved
@cloudvenger
Copy link
Contributor Author

All changed are done @bal7hazar and @tekkac :)

@bal7hazar , I had error during generation of docs, so I reverted and did not generate the new docs. Can we merge this PR and update the docs in the next one (to not block the src repo).

bal7hazar
bal7hazar previously approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@bal7hazar bal7hazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudvenger cloudvenger requested a review from bal7hazar December 2, 2022 10:48
bal7hazar
bal7hazar approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@bal7hazar bal7hazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tekkac
tekkac approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@tekkac tekkac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudvenger cloudvenger merged commit 32fbe43 into Carbonable:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekkac tekkac tekkac approved these changes

@bal7hazar bal7hazar bal7hazar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Yielder] Implement Starkvest create vestings feature for all farmer for a period
3 participants
@cloudvenger @bal7hazar @tekkac