Quick Pipe #69
Merged
Quick Pipe #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It needs a way to notify the pipeline what type of image it wants, as well as doubling the pipeline and double-tracking progress, though.
Eventually I want to have the user set the size.
Also fix the settings revert buttons.
Last commit corrected it being enabled after the quick preview. But it overcorrected; it never became available again. Now it works properly.
Also fix a bug where when reloading from db or by cloning, the validity was incorrectly set too low
It disables the drag handles until the full size image is ready.
I first redid the Edit state machine for loading images, cleaning it up a lot. That didn't fix it, but then I found that the sliders were updating position (but not moving) upon mouse release... That meant that the quick image would be reloaded, but not displayed because no parameters were changed. Likewise, the full size image would not be recomputed, so the histogram would be from the low res image and not the high res one. Weird, fun, funky. Death to all bugs!
Stealing the demosaiced image from quick pipe makes it respond a lot faster to a new image. With an adjustable resolution, you can now make the quick pipeline sharper to your taste, at the tradeoff of responsiveness.
Not just ones earlier in the pipeline, also ones that are later. This dramatically improves responsiveness for certain tasks.
If you don't have write permissions somewhere up in the directory tree then it'll cut you off. It might not work on Windows in some circumstances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, this dramatically increases the responsiveness of the UI by rendering a small-size image before the full size image.