-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for multiple camera lenses on iOS #174
base: main
Are you sure you want to change the base?
Conversation
- Add LensInfo struct for lens metadata - Add lens tracking to CameraController - Update configureCaptureDevices to discover all lens types - Add lens switching functionality - Add public methods: listLense, changeLense, getCurrentLense Co-Authored-By: Martin DONADIEU <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-Authored-By: Martin DONADIEU <[email protected]>
Co-Authored-By: Martin DONADIEU <[email protected]>
Co-Authored-By: Martin DONADIEU <[email protected]>
Co-Authored-By: Martin DONADIEU <[email protected]>
Co-Authored-By: Martin DONADIEU <[email protected]>
Co-Authored-By: Martin DONADIEU <[email protected]>
Co-Authored-By: Martin DONADIEU <[email protected]>
Add support for multiple camera lenses on iOS devices. This adds the ability to list available lenses, switch between them, and get information about the current lens.
Features
Example Usage
Testing Instructions
Test listLense on devices with multiple lenses
Test changeLense with:
Test getCurrentLense:
Verify existing functionality:
Verify Android behavior is unchanged
Notes
Link to Devin run: https://app.devin.ai/sessions/118241707373429f83a1cf5fab0e3b73
Requested by: Martin