Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation & remove dist files #90

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

yavyx
Copy link
Contributor

@yavyx yavyx commented Nov 19, 2024

  • Minor documentation update before stable release v3.1.1
  • Remove dist files

@yavyx yavyx requested review from mshadbolt and daisieh November 19, 2024 21:01
@mshadbolt
Copy link
Contributor

I made a change to update the version in the pyproject.toml file
Do we also need to rebuild the files in the dist before the stable release? (@daisieh question)

@daisieh
Copy link
Member

daisieh commented Nov 20, 2024

Honestly I think that the dist files shouldn't be in the repo at all...I think that they are necessary if we plan to distribute to pypi, but not if we're just linking to github.

Copy link
Member

@daisieh daisieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yavyx yavyx changed the title Update documentation Update documentation & remove dist files Nov 22, 2024
@yavyx yavyx merged commit 8397452 into develop Nov 22, 2024
1 check passed
@yavyx yavyx deleted the yavyx/update-docs branch November 22, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants