Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIG-1630: Match chromosomes with single digits/letters #35

Merged
merged 2 commits into from
May 6, 2024
Merged

DIG-1630: Match chromosomes with single digits/letters #35

merged 2 commits into from
May 6, 2024

Conversation

mshadbolt
Copy link
Contributor

@mshadbolt mshadbolt commented May 6, 2024 •
edited
Loading

  • Adds a 1, to the regex so that it will match when a chromosome is passed in with a single digit or letter (previously only matched if there were two digits/letters)

@mshadbolt mshadbolt requested a review from OrdiNeu May 6, 2024 19:10
OrdiNeu
OrdiNeu approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@OrdiNeu OrdiNeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; we did not have test data with a single digit/letter so that's probably why it was uncaught until now.

query_server/query_operations.py Outdated Show resolved Hide resolved
@mshadbolt mshadbolt merged commit 8e3aed3 into develop May 6, 2024
@mshadbolt mshadbolt deleted the mshadbolt/fix-genomic-search-bug branch May 6, 2024 19:56
@candigbot candigbot mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrdiNeu OrdiNeu OrdiNeu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshadbolt @OrdiNeu