Protect against a few null cases #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshadbolt
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Pulled the branch and did integration tests as well as ingesting new small dataset. Everything worked as expected except that test_query_genomic(), if no results are returned from the search then all donors are displayed in the clinical data. Not sure if this is intentional or we should change it to behave so that if there are no donors matching the genomic search then the table is blank? (probably an issue for another ticket, will approve this change for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was only one section left where we weren't checking nullness before using values returned from Katsu -- this fixes that.