-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change 'cancer_type' to 'primary_site' and support Censoring #144
Conversation
a8f8f29
to
0d3b2d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that the tooltips have changed and are now displaying differently, as shown in the attached picture for the map view. We should check if this issue affects other tooltips as well
On the search page where the graphs are not displaying any data because of AGGREGATRE_COUNT_THRESHOLD. Additionally, the "Attention" section is not visible for the data visualization when data is showing nothing. This is confusing because the clinical table shows data, but the graphs and patient count at the top both display 0.
@@ -283,6 +283,7 @@ export const processCondtionsListData = (dataObject) => { | |||
|
|||
/** | |||
* Process data for cancerType list | |||
* NB: Unused? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dont use this anymore it can be removed. I think we originally kept it when we were making the search page but wasn't removed once it was finished.
I've given it a once-over, should be fixed now. |
…mpleteness endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once Marions bug is taken care of on CanDIGv2
Ticket(s)
Description
cancer_type_count
toprimary_site_count
internally. Requires the corresponding PRs from Katsu and Query.Best tested from CanDIGv2's
feature/censoring-and-rename-cancer-type
branchScreenshots
After
(With editing the small MoHCCN dataset so that more people had base of mouth as their primary site:)
![image](https://private-user-images.githubusercontent.com/4656440/334832708-71488183-71ed-4784-948b-fce40653be07.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTc1MTMsIm5iZiI6MTczOTE5NzIxMywicGF0aCI6Ii80NjU2NDQwLzMzNDgzMjcwOC03MTQ4ODE4My03MWVkLTQ3ODQtOTQ4Yi1mY2U0MDY1M2JlMDcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTBUMTQyMDEzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTA2ZTQ0ODZiN2MwZjMyNTMyOTZkMTM0MDBiYjhmZGM2NTk5NWYxZjkwZTEzYzBlNzg5YjNiOWY4MWI3MGUzMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.B4_kGykR_Wa_KLp-RnV1H2mSc9T_tuUq0HDQGSEtKW8)
Types of Change(s)
Has it been tested for: