Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'cancer_type' to 'primary_site' and support Censoring #144

Merged
merged 11 commits into from
Jun 6, 2024

Conversation

OrdiNeu
Copy link
Contributor

@OrdiNeu OrdiNeu commented May 21, 2024

Ticket(s)

Description

  • Changes cancer_type_count to primary_site_count internally. Requires the corresponding PRs from Katsu and Query.
  • Handles censored data types properly

Best tested from CanDIGv2's feature/censoring-and-rename-cancer-type branch

Screenshots

After

image

(With editing the small MoHCCN dataset so that more people had base of mouth as their primary site:)
image

Types of Change(s)

  • 🪲 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Has it been tested for:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • Prettier linter doesn't return errors
  • Production branch PR browser testing: Chrome, Firefox, Edge, etc.
  • Locally tested
  • Dev server tested
  • Production tested when merging into stable/production branch
  • Runbook tasks pass locally/on UHN-Dev
  • If visuals have changed, Runbook has been updated with new screenshots

@OrdiNeu OrdiNeu force-pushed the feature/change-to-primary-site branch from a8f8f29 to 0d3b2d8 Compare May 24, 2024 20:07
@OrdiNeu OrdiNeu changed the title Change 'cancer_type' to 'primary_site' Change 'cancer_type' to 'primary_site' and support Censoring May 24, 2024
Copy link
Member

@CourtneyGosselin CourtneyGosselin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the tooltips have changed and are now displaying differently, as shown in the attached picture for the map view. We should check if this issue affects other tooltips as well
image
screencapture-candig-docker-internal-5080-clinicalGenomicSearch-2024-05-27-12_10_42

On the search page where the graphs are not displaying any data because of AGGREGATRE_COUNT_THRESHOLD. Additionally, the "Attention" section is not visible for the data visualization when data is showing nothing. This is confusing because the clinical table shows data, but the graphs and patient count at the top both display 0.

@@ -283,6 +283,7 @@ export const processCondtionsListData = (dataObject) => {

/**
* Process data for cancerType list
* NB: Unused?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont use this anymore it can be removed. I think we originally kept it when we were making the search page but wasn't removed once it was finished.

@OrdiNeu
Copy link
Contributor Author

OrdiNeu commented May 28, 2024

It appears that the tooltips have changed and are now displaying differently, as shown in the attached picture for the map view. We should check if this issue affects other tooltips as well

I've given it a once-over, should be fixed now.

@OrdiNeu OrdiNeu requested a review from CourtneyGosselin May 28, 2024 16:55
Copy link
Member

@CourtneyGosselin CourtneyGosselin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once Marions bug is taken care of on CanDIGv2

@OrdiNeu OrdiNeu merged commit 021ffa9 into develop Jun 6, 2024
4 checks passed
@OrdiNeu OrdiNeu deleted the feature/change-to-primary-site branch June 6, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants