Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIG-1628: Change axis label to sample registrations #140

Merged
merged 1 commit into from
May 3, 2024

Conversation

mshadbolt
Copy link
Contributor

@mshadbolt mshadbolt commented May 3, 2024

Ticket(s)

  • DIG-1628

Description

  • update the axis for genomic completeness graphs so that it reflects what is being counted

Expected Behaviour

  • x axis on genomic completeness graphs is 'Number of Sample Registrations' instead of 'Number of Patients'

Screenshots (if appropriate)

Before PR

Screenshot 2024-05-03 at 2 08 38 PM

After PR

Screenshot 2024-05-03 at 2 07 43 PM

Types of Change(s)

  • 🪲 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Has it been tested for:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • Prettier linter doesn't return errors
  • Production branch PR browser testing: Chrome, Firefox, Edge, etc.
  • Locally tested
  • Dev server tested
  • Production tested when merging into stable/production branch
  • Runbook tasks pass locally/on UHN-Dev
  • If visuals have changed, Runbook has been updated with new screenshots

Copy link
Member

@CourtneyGosselin CourtneyGosselin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repo has one eslint warning they are bit hard to catch because it still shows the check mark in the tests since its just a warning. It can be fixed in a later PR too
image

@mshadbolt mshadbolt changed the title change axis label to samples DIG-1628: Change axis label to sample registrations May 3, 2024
@mshadbolt mshadbolt merged commit a404775 into develop May 3, 2024
4 checks passed
@mshadbolt mshadbolt deleted the mshadbolt/change-genomic-xaxis branch May 3, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants