This repository has been archived by the owner on Oct 14, 2020. It is now read-only.
fix: return a null token if the token is invalid or fails verification #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonestristand
changed the title
|
Awesome work! Thanks for your contribution 🙏 |
|
Fix is available in version 1.1.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, with the most recent build of nexus, passing an invalid Bearer token in the authorization header causes jsonwebtoken to throw an error on verify(...), which is not caught properly by nexus and results in unhandledRejection which terminates the nexus application.
This PR adds a try/catch block around jsonwebtoken.verify to return a null token in the context if the token provided is invalid (same behaviour as if the Authorization header was invalid)