Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNTAX] Make LinkTapArea a link #595

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

ChessyHsu
Copy link
Contributor

@ChessyHsu ChessyHsu commented Nov 6, 2024

Followup on creating a LinkTapArea #592

  1. Change LinkTapArea from a button to a link:
    TapArea is a button made by div with onClick taking in synthetic events while LinkTapArea should naturally be a link and thus its onClick takes in mouse events.
  2. Remove the disable attribute: since clicking on a link trigger a redirection to other page, it should always be available and does not need to wait for actions to complete.

image

Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 3761bbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syntax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 8:47pm

@ChessyHsu ChessyHsu changed the title make LinkTapArea a link [SYNTAX] Make LinkTapArea a link Nov 6, 2024
@ChessyHsu ChessyHsu marked this pull request as ready for review November 6, 2024 20:43
@nathan-ong
Copy link
Contributor

@ChessyHsu , can you include screenshots?

@ChessyHsu
Copy link
Contributor Author

@ChessyHsu , can you include screenshots?

Yes, screenshot is added!

@ChessyHsu ChessyHsu merged commit d41d529 into Cambly:main Nov 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants