Allow option to preserve whitespace for Typography content #577
Conversation
🦋 Changeset detectedLatest commit: 16d4add The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| * | ||
| * @defaultValue "inherit" | ||
| */ | ||
| whiteSpace?: |
There was a problem hiding this comment.
hmm. generally, we've limited alot of these props to only the ones we need. ive inherited christian's rather be more strict and then if we need the others ones we'll add it later
how often do you think we'll need all of these?
i imagine just inherit, normal, nowrap and pre will be fine
There was a problem hiding this comment.
For the current use case we want pre-line so that we can preserve line breaks but still wrap.
I'll limit it to inherit, normal, nowrap and pre-line for now.
Unless you think there's a use case for pre as well:
There was a problem hiding this comment.
just the ones you mentioned are fine. thanks!
There was a problem hiding this comment.
just the ones you mentioned are fine. thanks!
Done!
dasfrosty
force-pushed
the
niels/typography-preserve-line-breaks-option
branch
from
1e84c7d to
16d4add
Compare
Changes
Add support to
Typographycomponent for setting white-space CSS property.Screenshots
For example: