Tabs.Link: fix selected state on=darkBackground #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 8ada765 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
christianvuerings
force-pushed
the
christian/fix-selectedTabDarkBackground
branch
from
a7fcc78 to
8ada765
Compare
zprong
approved these changes
Jun 10, 2024
| @@ -57,7 +57,7 @@ const TabLink = forwardRef<HTMLAnchorElement, TabLinkProps>( | |||
| [styles.unselectedTab]: !selected, | |||
| [styles.selectedTabOnLightBackground]: | |||
| selected && on === "lightBackground", | |||
| [styles.selectedTabDarkBackground]: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Noticed the following issue in VSCode:
Note that this TS issue doesn't fail the build because of this outstanding TS ticket to support plugins during compilation:
Before (incorrect selected state)
After
Notes
Also added a light / dark toggle to the
Tabs.Linkexample so we can easily test: