Remove disable in storybook and tests

Cambly · Nov 6, 2024 · 4105d9e · 4105d9e
1 parent f90b9cd
commit 4105d9e
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 27 deletions.
diff --git a/packages/syntax-core/src/Button/Button.tsx b/packages/syntax-core/src/Button/Button.tsx
@@ -114,20 +114,20 @@ const Button = forwardRef<HTMLButtonElement, ButtonProps>(
     {
       "data-testid": dataTestId,
       text,
-      loadingText,
+      // loadingText,
       color = "primary",
       size = "md",
-      accessibilityLabel,
-      disabled = false,
+      // accessibilityLabel,
+      // disabled = false,
       loading = false,
       fullWidth = false,
       startIcon: StartIcon,
       endIcon: EndIcon,
       on = "lightBackground",
       onClick,
-      tooltip,
-      type = "button",
-    }: ButtonProps,
+    }: // tooltip,
+    // type = "button",
+    ButtonProps,
     ref,
   ) => {
     const isHydrated = useIsHydrated();

diff --git a/packages/syntax-core/src/LinkButton/LinkButton.tsx b/packages/syntax-core/src/LinkButton/LinkButton.tsx
@@ -112,9 +112,9 @@ const LinkButton = forwardRef<HTMLAnchorElement, LinkButtonProps>(
   (
     {
       text,
-      href,
-      target,
-      rel,
+      // href,
+      // target,
+      // rel,
       "data-testid": dataTestId,
       color = "primary",
       size = "md",

diff --git a/packages/syntax-core/src/LinkTapArea/LinkTapArea.stories.tsx b/packages/syntax-core/src/LinkTapArea/LinkTapArea.stories.tsx
@@ -68,10 +68,6 @@ export const Default: StoryObj<typeof LinkTapArea> = {
   render: ({ ...args }) => <LinkTapArea {...args} />,
 };
 
-export const Disabled: StoryObj<typeof Default> = {
-  args: { ...Default.args, disabled: true },
-};
-
 const roundingLookup = {
   sm: "8px",
   md: "12px",

diff --git a/packages/syntax-core/src/LinkTapArea/LinkTapArea.test.tsx b/packages/syntax-core/src/LinkTapArea/LinkTapArea.test.tsx
@@ -90,20 +90,6 @@ describe("linkTapArea", () => {
     expect(handleTap).toHaveBeenCalledTimes(1);
   });
 
-  it("does not fire the onClick when clicked and the LinkTapArea is disabled", async () => {
-    const handleTap = vi.fn();
-    render(
-      <LinkTapArea
-        disabled
-        data-testid="link-tap-area-testid"
-        onClick={handleTap}
-      />,
-    );
-    const linkTapArea = await screen.findByTestId("link-tap-area-testid");
-    await userEvent.click(linkTapArea);
-    expect(handleTap).toHaveBeenCalledTimes(0);
-  });
-
   it("sets an accessibility label", async () => {
     render(
       <LinkTapArea