This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
Speedup of summary_data_from_transaction_data #237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced pd.period instances with timestamps for the actual calculations / aggregations which yields a speedup of several factors x10 on large datasets. For a dummy dataset with 100000 entries execution time drops from ~7 seconds to 0.13 seconds on my machine.
.to_period is still applied to truncate dates (more consistently in fact) which means results should remain largely unaffected.
Note that starting from pandas 0.24.0 some or all of the operations involving pd.period will also be considerably faster, however, the calculations via timestamps (i.e. integers) here should still have an edge by a couple of factors.