Make regex in Parser case-insensitive with a timeout #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated LongFormatRegularExpression in the Parser class to be case-insensitive by adding RegexOptions.IgnoreCase. Also set a timeout of 10 seconds using TimeSpan.FromSeconds(10) to prevent potential performance issues from long-running regex operations.
KasperSK
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Would this not change how Event and Action is parsed? So we match both Event and event?
Would that not break later string replace that looks for Event in uppercase?
|
good point going to close this pr |
vb2ae
deleted the
890-parserparse-dependencyobject-target-string-text-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated LongFormatRegularExpression in the Parser class to be case-insensitive by adding RegexOptions.IgnoreCase. Also set a timeout of 10 seconds using TimeSpan.FromSeconds(10) to prevent potential performance issues from long-running regex operations.