Fixed #682 - AssemblySource throws ArgumentExceptions #687
Conversation
…eys. This catches the ArgumentExeption and continues instead of breaking. Also includes the DesignTime part, even though this never occurred there but keeps code the same style in both methods.
|
Sorry, see my other issue #688 ... had to do by hand. How to run the checks locally? Works on my machine. ;-) How can I help to fix this? Don't know why net-core Bootstrapper has effects on the builds of Xamarin etc. |
Don't know why changes for net-core Bootstrapper have effects on the builds of Xamarin etc. This should make the code more or less equal to what was done before except for catching the Exception and doing Add() instead of AddRange(). This removes the check in the AssemblySource instance cache.
…problem of my commit, so reverted back to initial suggestion. This reverts commit 56cf304.
The build error was not my fault... so I reverted back to the original submit. |
|
I would like to help you out but I'm not familar with the Xamarin platform. Do you need help there? Looking forward to see a new -alpha/-beta (-release?) version including my fix. ;-) |
| @@ -83,7 +83,19 @@ public void Initialize() | |||
| protected virtual void StartDesignTime() | |||
| { | |||
| AssemblySource.Instance.Clear(); | |||
| AssemblySource.Instance.AddRange(SelectAssemblies()); | |||
|
|
|||
| foreach (var assembly in SelectAssemblies()) | |||
There was a problem hiding this comment.
Looks like the formatting is off here.
There was a problem hiding this comment.
Looks good when looking at the file alone. I was not able to see in the file, only in the diff. I look for this tomorrow. As I wrote in the other issue I was not able to build/open using Visual Studio to check the solution. So pre-configured settings from you may not applied here.
There was a problem hiding this comment.
|
Actually wondering if we can push the check into |
|
Happy to see it there, but can not test the other platforms here. Maybe just go for TryAdd instead of Add? |
|
Pushed a fix to |
... for duplicate keys. This catches the ArgumentExeption and continues instead of breaking. Also includes the DesignTime part, even though this never occurred there but keeps code the same style in both methods.