-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .NET Core 3.0 target to Caliburn.Micro.Platform #626
Conversation
Looking really good, thanks. Need to sort out why PR builds aren't happening to test this out. |
I've enabled PR builds on forks so any further changes should be built for you (in theory). |
Could you change the SDK to one that supports .NET Core 3.0? Build is currently failing with |
Having some issues updating the pipeline.
Will work through it some more tonight. |
For more information about why this necessary take a look here http://www.rudyhuyn.com/blog/2019/08/05/how-to-fix-certificate-does-not-match-supplied-signing-thumbprint/
Glad we managed to get there together |
Thanks for the hard work @mjuen |
No problem :) It is truly nerve wracking when you assume that the pipeline works after fixing several errors and then the next one appears. |
Hate having to fix pipelines, leaves a lot of terrible commit history. |
As #609 seems to be stuck at the moment I took the liberty to replicate the changes and include the review suggestions from @nigel-sampson.
I also renamed the folder containing the shared files from
net46
tonet46-netcore
.