Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET Core 3.0 target to Caliburn.Micro.Platform #626

Merged
merged 9 commits into from
Aug 15, 2019
Merged

Add .NET Core 3.0 target to Caliburn.Micro.Platform #626

merged 9 commits into from
Aug 15, 2019

Conversation

mjuen
Copy link
Contributor

@mjuen mjuen commented Aug 9, 2019

As #609 seems to be stuck at the moment I took the liberty to replicate the changes and include the review suggestions from @nigel-sampson.

I also renamed the folder containing the shared files from net46 to net46-netcore.

@mjuen mjuen marked this pull request as ready for review August 9, 2019 18:11
@nigel-sampson
Copy link
Contributor

Looking really good, thanks. Need to sort out why PR builds aren't happening to test this out.

@nigel-sampson
Copy link
Contributor

nigel-sampson commented Aug 14, 2019

I've enabled PR builds on forks so any further changes should be built for you (in theory).

@mjuen
Copy link
Contributor Author

mjuen commented Aug 14, 2019

I've enabled PR builds on forks so any further changes should be built for you (in theory).

Could you change the SDK to one that supports .NET Core 3.0?

Build is currently failing with The current .NET SDK does not support targeting .NET Core 3.0. Either target .NET Core 2.2 or lower, or use a version of the .NET SDK that supports .NET Core 3.0.

@nigel-sampson
Copy link
Contributor

Having some issues updating the pipeline.

##[error]C:\Users\VssAdministrator.nuget\packages\msbuild.sdk.extras\2.0.31\Sdk\Sdk.props(16,5): Error MSB4184: The expression "[System.IO.Path]::GetDirectoryName('')" cannot be evaluated. The path is not of a legal form.

Will work through it some more tonight.

@nigel-sampson
Copy link
Contributor

Glad we managed to get there together

@nigel-sampson nigel-sampson merged commit 7758a9e into Caliburn-Micro:master Aug 15, 2019
@nigel-sampson
Copy link
Contributor

Thanks for the hard work @mjuen

@mjuen
Copy link
Contributor Author

mjuen commented Aug 15, 2019

No problem :)

It is truly nerve wracking when you assume that the pipeline works after fixing several errors and then the next one appears.

@nigel-sampson
Copy link
Contributor

Hate having to fix pipelines, leaves a lot of terrible commit history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants