add package lock #398
Merged
add package lock #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emilefokkemanavara I personally use pnpm or yarn as a package manager. Curious on your thoughts of moving this to pnpm, adding a pnpm lock file etc? |
|
@chris-pardy pnpm is fine by me. Something like this? |
|
@emilefokkemanavara yeah. we'll also need to update the deploy action. |
chris-pardy
approved these changes
Nov 18, 2024
done. |
|
@chris-pardy this ok to merge? |
chris-pardy
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build fails because of recent changes around typescript-eslint. Let's stick to a version that works for us.
npm ciinstead ofnpm installin CI