[CBRD-24929] Add identifier comparator class and refactor comparision of catalog names #4563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifiers and support functions according to the CUBRID's definition
ctshim
approved these changes
Aug 9, 2023
mhoh3963
reviewed
Aug 10, 2023
src/object/schema_system_catalog.cpp
Outdated
|
|
||
| bool sm_check_system_class_by_name (const std::string &name) | ||
| { | ||
| return cubschema::sm_catalog_names.is_exists (name); |
There was a problem hiding this comment.
The system class name can't be contained dot(.).
So, before execute sm_catalog_names.is_exists(), how about checking if there is "." and returning false if there is ?
There was a problem hiding this comment.
Thank you for the review. In CUBRID's identifier writing rule, "." is not allowed in both cases whether a name is enclosed (by quotes) or not.
- I've added a new static function,
check_identifier_is_valid, which checks name is a valid identifier according to the name enclosed. (40c3c1e) - In
check_identifier_condition()in identifier_store, changed to usecheck_identifier_is_valid()above. - I don't think the function check_identifier_is_valid() is in right place. We need to implement a unified identifier writing rule checker needs somewhere. Before then, I'm going to leave it here.
mhoh3963
approved these changes
Aug 10, 2023
|
@hgryoo |
System table names, such as _db_class, _db_attribute, do not follow the identifier's writing rules. Because of the checking identifier's validation, createdb failed in CI because of added logic at 40c3c1e. |
…actor trivial string -> string_view
hyunikn
approved these changes
Aug 11, 2023
beyondykk9
approved these changes
Aug 16, 2023
hgryoo
added a commit
that referenced
this pull request
Oct 17, 2023
… of catalog names (#4563) http://jira.cubrid.org/browse/CBRD-24929 Add a class to provide a unified routine to compare identifiers. - string_utility.hpp: For C++ STL's string comparison, lowercase_hash and lowercase_compare structs are added, string_set_ci_lower is defined - identifier_store.hpp: the constructor gets a set of identifier lists and provides is_exists () API. Refactor comparison routine related to system catalog names - schema_system_catalog.[cpp|hpp]: Use the new API of identifier_store for system catalogs - remove legacy duplicated routine (util_common.c, utility.h, load_server_loader.cpp...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-24929