Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-20564] Optimizes heap operations by creating log node before fixing the page #303

Open
wants to merge 108 commits into
base: develop
Choose a base branch
from

Conversation

alexstanro
Copy link
Contributor

No description provided.

@cubridci
Copy link

cubridci commented Mar 9, 2017

Build comment file:

File: src/storage/heap_file.c (1 incorrect indentation(s) found)

 15972 	}

Please run 'indent -l120 -lc120' to correct the indentation


@cubridci
Copy link

cubridci commented Mar 9, 2017

Build comment file:

File: src/storage/heap_file.c (3 incorrect indentation(s) found)

 15972 	}
 23961 	      /* the log info has changed, need to recreate the log node */
 23971 	      /* the log info has changed, need to recreate the log node */

Please run 'indent -l120 -lc120' to correct the indentation


@cubridci
Copy link

cubridci commented Mar 9, 2017

Build comment file:

File: src/storage/heap_file.c (4 incorrect indentation(s) found)

 15972 	}
 16068   HEAP_LOG_INFO delete_log_info;
 23966 	      /* the log info has changed, need to recreate the log node */
 23976 	      /* the log info has changed, need to recreate the log node */

Please run 'indent -l120 -lc120' to correct the indentation


@cubridci
Copy link

Build comment file:

File: src/base/system_parameter.c (1 incorrect indentation(s) found)

  6244 	      || strcmp (prm->name, PRM_NAME_SERVER_TIMEZONE) == 0 || strcmp (prm->name, PRM_NAME_TIMEZONE) == 0))

Please run 'indent -l120 -lc120' to correct the indentation


@cubridci
Copy link

Build comment file:

File: src/base/system_parameter.c (1 incorrect indentation(s) found)

  6244 	      || strcmp (prm->name, PRM_NAME_SERVER_TIMEZONE) == 0 || strcmp (prm->name, PRM_NAME_TIMEZONE) == 0))

Please run 'indent -l120 -lc120' to correct the indentation


@cubridci
Copy link

Build comment file:

File: src/base/system_parameter.c (1 incorrect indentation(s) found)

  6244 	      || strcmp (prm->name, PRM_NAME_SERVER_TIMEZONE) == 0 || strcmp (prm->name, PRM_NAME_TIMEZONE) == 0))

File: src/storage/heap_file.c (2 incorrect indentation(s) found)

   974 						  short *flag_vacuum_status);
 25595 				      short *flag_vacuum_status)

Please run 'indent -l120 -lc120' to correct the indentation


@cubridci
Copy link

Build comment file:

File: src/base/system_parameter.c (1 incorrect indentation(s) found)

  6244 	      || strcmp (prm->name, PRM_NAME_SERVER_TIMEZONE) == 0 || strcmp (prm->name, PRM_NAME_TIMEZONE) == 0))

Please run 'indent -l120 -lc120' to correct the indentation


@hornetmj
Copy link
Contributor

@mhoh3963 This PR is too old. How about closing it?

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2021

Codecov Report

Merging #303 (dfde60a) into develop (55f4896) will decrease coverage by 6.97%.
The diff coverage is 51.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #303       +/-   ##
============================================
- Coverage    52.62%   45.65%    -6.98%     
============================================
  Files          490      328      -162     
  Lines       389285   237014   -152271     
============================================
- Hits        204865   108209    -96656     
+ Misses      184420   128805    -55615     
Impacted Files Coverage Δ
src/base/perf_monitor.c 7.44% <ø> (-5.22%) ⬇️
src/base/perf_monitor.h 15.85% <ø> (-36.28%) ⬇️
src/base/system_parameter.c 54.29% <ø> (-1.23%) ⬇️
src/cm_common/cm_mem_cpu_stat.c 0.00% <ø> (ø)
src/executables/compactdb.c 0.00% <0.00%> (ø)
src/storage/btree.h 0.00% <ø> (-71.43%) ⬇️
src/storage/catalog_class.c 60.02% <ø> (-8.72%) ⬇️
src/storage/compactdb_sr.c 0.00% <ø> (ø)
src/storage/heap_file.c 46.39% <ø> (-5.82%) ⬇️
src/transaction/lock_manager.c 29.45% <ø> (-3.67%) ⬇️
... and 498 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f4896...dfde60a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants