[TOOLS-4684] Apply Oracle PL/SQL Procedure Parser to CMT #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kang-dot
approved these changes
Dec 12, 2024
kisoo-han
approved these changes
Dec 12, 2024
Srltas
merged commit 10c4204
into
CUBRID:release/oracle_procedure_migration
3 checks passed
hwany7seo
reviewed
Dec 16, 2024
| } | ||
|
|
||
| @Override | ||
| public void enterRoutine_definition(PloParser.Routine_definitionContext ctx) { |
There was a problem hiding this comment.
Function에 underscore를 추가한 이유를 알 수 있을까요?
java 메소드이기때문에 제거하는 것이 좋지 않을까 합니다.
There was a problem hiding this comment.
해당 소스 코드는 현익님께서 만드신 코드라 C 언어 스타일로 작성된 부분이 있는거 같습니다.
저도 이 부분은 Java 코드 스타일과는 맞지 않다고 생각해 수정하도록 하겠습니다.
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { |
There was a problem hiding this comment.
반복문이 아닌 경우 o라는 변수보다는 obj로 표현하는 것이 더 좋지 않을까요?
There was a problem hiding this comment.
저도 코드에서 명확한 변수명을 사용하는 것이 더 좋다고 생각합니다.
enterRoutine_definition를 수정하면서 이 부분도 수정하도록 하겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/TOOLS-4684
Purpose
Implementation
N/A
Remarks
Oracle PL/SQL Procedure Parser - TOOLS-4683