Replace KV registration form with custom registration API #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drnlm
requested changes
Apr 12, 2017
| @@ -22,6 +23,7 @@ | |||
| # Specification taken from https://support.twitter.com/articles/101299 | |||
| TwitterValidator = RegexValidator('^[A-Za-z0-9_]{1,15}$', | |||
| 'Incorrectly formatted twitter handle') | |||
| is_registered = import_string(settings.WAFER_USER_IS_REGISTERED) | |||
There was a problem hiding this comment.
Is it worth catching ImportError and returning a message that explicitly points to the WAFER_USER_IS_REGISTERED setting, rather than just the raw error?
| # you implement your own registration system. | ||
| WAFER_REGISTRATION_MODE = 'ticket' | ||
| # WAFER_USER_IS_REGISTERED should return a boolean, when passed a Django user. | ||
| WAFER_USER_IS_REGISTERED = 'wafer.tickets.models.user_is_registered' |
There was a problem hiding this comment.
We should add this to the documentation, rather than just having comments in the settings file
|
@stefanor Should we try land this? |
Merged
While it made implementing a registration form really simple, it made dealing with the registration data rather complex.
stefanor
force-pushed
the
other-registration-approaches
branch
from
6358501 to
228a876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't very satisfied with the KV registration approach we used for DebConf16. While this framework made implementing the form really nice and easy, the data was completely unusable in Django admin, which made dealing with the data a lot harder.
I think if you find yourself needing some sort of registration form, you're really better off throwing a django model + form together, yourself. So, here's a simple API to let wafer know if a user is registered, when you have done that.
We could leave the KV registration framework in place, but I don't know if I want to inflict it on anyone else :)