Update Rstudio Helm Chart #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
trispera
commented
Apr 25, 2024
trispera
commented
- Add NGINX in front of Rstudio for authentication
- Route points NGINX
- Add secret with USER and PASSWORD to connect to Rstudio
- Update README and NOTES.txt
- Add NGINX in front of Rstudio for authentication - Route points NGINX - Add secret with USER and PASSWORD to connect to Rstudio - Update README and NOTES.txt
|
Not working for me now
|
lvarin
reviewed
Apr 25, 2024
charts/rstudio/templates/NOTES.txt
Outdated
| @@ -15,6 +15,11 @@ You can retrieve Rstudio URL via this command: | |||
| export RSTUDIO=$(oc get route --namespace {{ .Release.Namespace }} -o yaml | yq '.items[0].spec.host') | |||
There was a problem hiding this comment.
Yes. It assumes you don't have other routes already deployed. With your namespace, it'll return other values.
Need to find a better way for this one. With annotations maybe 🤔
There was a problem hiding this comment.
You know the name of the route before hand, isn't it? Why not use that?
There was a problem hiding this comment.
$ oc get route rstudio -n test-helm-charts -o yaml | yq .spec.host
"pedropedro.2.rahtiapp.fi.2.rahtiapp.fi"There was a problem hiding this comment.
With this update I know. It wasn't the case before. I'll do the change
|
Did you wait for the build to complete before accessing it? |
|
Shame No, i did not |
|
Now it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.