Generalise toposort to LinkView #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, messed up my git manip, will be ready soon! |
|
It's ready now! |
|
Side note: this could also be implemented on any |
lmondada
force-pushed
the
feature/topsort-linkview
branch
from
8ec7c84 to
8241d74
Compare
lmondada
force-pushed
the
feature/topsort-linkview
branch
from
8241d74 to
38d02f5
Compare
Merged
aborgna-q
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Nice!
Petgraph already has a toposort algo. There's a benchmark here that compares both implementations (and petgraph's was faster last time I checked!)
That implementation allocates a vector with the result instead of returning the iterator. We currently use petgraph's in Hugr, but imho both are useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.