Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SecondaryMap for HashSet and HashMap #60

Closed
wants to merge 2 commits into from

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Jun 5, 2023

Closes #55

The changes are mostly filling the trait impls.
I had to add the StaticDefault trait because SecondaryMap needs to always be able to return a reference to a default value. (Note: Replaced with ConstDefault from the const_default crate).

@aborgna-q aborgna-q requested a review from acl-cqc June 5, 2023 16:30
@aborgna-q aborgna-q force-pushed the feature/more-secondarymaps branch from 3b3b1d9 to 0ec2c43 Compare June 6, 2023 12:45
@aborgna-q aborgna-q marked this pull request as draft June 6, 2023 13:38
@aborgna-q
Copy link
Collaborator Author

Moving to a draft while experimenting with more flexible ways to define the default value.

@aborgna-q aborgna-q force-pushed the feature/more-secondarymaps branch from 0ec2c43 to 94dc508 Compare June 7, 2023 08:44
@aborgna-q
Copy link
Collaborator Author

I'm dropping this PR now that we can use petgraph's algorithms on filtered graphs.
It may still be useful to revisit it in the future.

@aborgna-q aborgna-q closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement SecondaryMap on sparse containers.
1 participant