fix: Link and neighbour iterators counting self-loops twice #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
all_links
iterator for bothPortgraph
andMultiportgraph
, andall_neighbours
for the latter yielded self-loops twice.This in turn caused
insert_graph
to try inserting repeated links, as reported in #130.This PR fixes the error and adds tests for that.
Fixes #130.
drive-by: Add missing checks in the pre-commit hook.