feat: Simpler convex checker, no longer requires &mut
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using the toposorted order and keeping track of nodes in the causal future.
aborgna-q
force-pushed
the
perf/convex-check
branch
from
3998258 to
2c2dfa2
Compare
ss2165
approved these changes
Oct 20, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
## 🤖 New release * `portgraph`: 0.9.0 -> 0.10.0 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## 0.10.0 (2023-10-20) ### Features - Simpler convex checker, no longer requires `&mut` ([#114](#114)) ### Miscellaneous Tasks - [**breaking**] Update pyo3 requirement from 0.19 to 0.20 ([#110](#110)) ### Doc - Add DEVELOPMENT.md </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Agustín Borgna <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConvexChecker now uses the pre-computed node toposort to compute traverse the subgraph nodes and their causal future in order.
This should end up processing less nodes than the previous version, and let us avoid the temporary datastructure that required
&mut checkerall throughout the API.I added some simple benchmarks, but unfortunately they are not the best at showing the improvements in this refactor (we end up traversing most of the nodes anyway).
In more real tests on
tket2I saw small improvements, but nothing to write home about.