tests: Add test of repeated adding of the same extension #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
approved these changes
Sep 18, 2023
| let mut windows = nodes.windows(2); | ||
| while let Some(&[src, tgt]) = windows.next() { | ||
| hugr.connect(src, 0, tgt, 0)?; | ||
| } |
There was a problem hiding this comment.
Validate it afterwards? Where would a broken inference fail?
acl-cqc
reviewed
Sep 18, 2023
src/extension/infer.rs
Outdated
| // Connect nodes in order (0 -> 1 -> 2 ...) | ||
| let nodes = [node0, node1, node2, node3, node4, node5]; | ||
| let mut windows = nodes.windows(2); | ||
| while let Some(&[src, tgt]) = windows.next() { |
There was a problem hiding this comment.
Can this be for &[src, tgt] in nodes.windows(2) {...} or something like that?
There was a problem hiding this comment.
Unfortunately that doesn't work quite as well because rust doesn't know at compile time the size of the window and complains that &[src, tgt] is a refutable pattern.
There was a problem hiding this comment.
You can use `tuple_windows instead.
croyzor
force-pushed
the
tests/inference-test
branch
from
3e668ac to
2228d35
Compare
croyzor
force-pushed
the
tests/inference-test
branch
from
2228d35 to
87d9345
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.