Skip to content

feat!: Removed model_unstable feature flag. #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

feat!: Removed model_unstable feature flag. #2113

merged 2 commits into from
Apr 25, 2025

Conversation

zrho
Copy link
Contributor

@zrho zrho commented Apr 23, 2025

This PR removes the model_unstable feature flag across the repository. Closes #2104.

BREAKING CHANGE: Downstream crates need to remove the model_unstable feature flag when referencing hugr or hugr-core.

@zrho zrho changed the title Removed model_unstable feature flag. feat: Removed model_unstable feature flag. Apr 23, 2025
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (2222b8c) to head (c6d66e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2113      +/-   ##
==========================================
+ Coverage   83.08%   84.58%   +1.49%     
==========================================
  Files         219      221       +2     
  Lines       41886    45344    +3458     
  Branches    37961    41287    +3326     
==========================================
+ Hits        34803    38356    +3553     
+ Misses       5278     5254      -24     
+ Partials     1805     1734      -71     
Flag Coverage Δ
python 86.17% <ø> (+0.46%) ⬆️
rust 84.43% <ø> (+1.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugrbot
Copy link
Collaborator

hugrbot commented Apr 23, 2025

This PR contains breaking changes to the public Rust API.

cargo-semver-checks summary

--- failure feature_missing: package feature removed or renamed ---

Description:
A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/feature_missing.ron

Failed in:
feature model_unstable in the package's Cargo.toml
feature hugr-model in the package's Cargo.toml

--- failure feature_missing: package feature removed or renamed ---

Description:
A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/feature_missing.ron

Failed in:
feature model_unstable in the package's Cargo.toml
feature hugr-model in the package's Cargo.toml

@zrho zrho changed the title feat: Removed model_unstable feature flag. feat!: Removed model_unstable feature flag. Apr 24, 2025
@aborgna-q
Copy link
Collaborator

Please update the release group in release-plz.toml too.

hugr/release-plz.toml

Lines 66 to 67 in 2222b8c

# Use a separate version group while the dependency is `-unstable`,
# to avoid breaking releases of the main package.

@zrho zrho marked this pull request as ready for review April 24, 2025 11:40
@zrho zrho requested a review from a team as a code owner April 24, 2025 11:40
@zrho zrho requested a review from cqc-alec April 24, 2025 11:40
@zrho zrho added this pull request to the merge queue Apr 25, 2025
Merged via the queue into main with commit 8ef4afb Apr 25, 2025
25 checks passed
@zrho zrho deleted the zrho/model-stable branch April 25, 2025 13:38
@hugrbot hugrbot mentioned this pull request Apr 25, 2025
@aborgna-q aborgna-q restored the zrho/model-stable branch April 28, 2025 09:34
@aborgna-q
Copy link
Collaborator

Note: The change has been reverted from main and put into a new PR targeting the release branch instead.

github-merge-queue bot pushed a commit that referenced this pull request Apr 28, 2025
Re-created from #2113, targeting the release branch instead.

BREAKING CHANGE: Downstream crates need to remove the model_unstable
feature flag when referencing hugr or hugr-core.

---------

Co-authored-by: Lukas Heidemann <[email protected]>
@aborgna-q aborgna-q deleted the zrho/model-stable branch April 28, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize hugr-model
4 participants