-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove unused dependencies #1935
Conversation
found using cargo-machete no easy way to remove unused entries from the workspace Cargo.toml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1935 +/- ##
=======================================
Coverage 83.71% 83.71%
=======================================
Files 196 196
Lines 37533 37533
Branches 34346 34346
=======================================
Hits 31422 31422
Misses 4328 4328
Partials 1783 1783
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary
|
@doug-q please check the llvm removals are valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes looks good, thanks!
Apparently this is a breaking change though, awkward |
found using cargo-machete
no easy way to remove unused entries from the workspace Cargo.toml
BREAKING CHANGE: Removed some unused dependencies from hugr-llvm test-utils feature.