Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove unused dependencies #1935

Merged
merged 1 commit into from
Feb 26, 2025
Merged

refactor!: remove unused dependencies #1935

merged 1 commit into from
Feb 26, 2025

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Feb 25, 2025

found using cargo-machete

no easy way to remove unused entries from the workspace Cargo.toml

BREAKING CHANGE: Removed some unused dependencies from hugr-llvm test-utils feature.

found using cargo-machete

no easy way to remove unused entries from the workspace Cargo.toml
@ss2165 ss2165 requested a review from a team as a code owner February 25, 2025 10:44
@ss2165 ss2165 requested a review from tatiana-s February 25, 2025 10:44
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.71%. Comparing base (929edb6) to head (ceebd2d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1935   +/-   ##
=======================================
  Coverage   83.71%   83.71%           
=======================================
  Files         196      196           
  Lines       37533    37533           
  Branches    34346    34346           
=======================================
  Hits        31422    31422           
  Misses       4328     4328           
  Partials     1783     1783           
Flag Coverage Δ
python 92.34% <ø> (ø)
rust 82.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugrbot
Copy link
Collaborator

hugrbot commented Feb 25, 2025

This PR contains breaking changes to the public Rust API.
Please deprecate the old API instead (if possible), or mark the PR with a ! to indicate a breaking change.

cargo-semver-checks summary

--- failure feature_missing: package feature removed or renamed ---

Description:
A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/feature_missing.ron

Failed in:
feature pathsearch in the package's Cargo.toml
feature serde in the package's Cargo.toml
feature typetag in the package's Cargo.toml
feature serde_json in the package's Cargo.toml

@ss2165 ss2165 requested review from doug-q and removed request for tatiana-s February 25, 2025 10:52
@ss2165
Copy link
Member Author

ss2165 commented Feb 25, 2025

@doug-q please check the llvm removals are valid

Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes looks good, thanks!

@doug-q
Copy link
Collaborator

doug-q commented Feb 25, 2025

Apparently this is a breaking change though, awkward

@ss2165 ss2165 changed the title chore: remove unused dependencies chore!: remove unused dependencies Feb 25, 2025
@ss2165 ss2165 changed the title chore!: remove unused dependencies refactor!: remove unused dependencies Feb 25, 2025
@ss2165 ss2165 added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit fcaf86f Feb 26, 2025
25 of 27 checks passed
@ss2165 ss2165 deleted the ss/machete branch February 26, 2025 07:34
@hugrbot hugrbot mentioned this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants