Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugr-model uses features from derive_more not declared in its cargo.toml #1939

Closed
aborgna-q opened this issue Feb 26, 2025 · 0 comments · Fixed by #1940
Closed

hugr-model uses features from derive_more not declared in its cargo.toml #1939

aborgna-q opened this issue Feb 26, 2025 · 0 comments · Fixed by #1940
Assignees
@aborgna-q
Labels
bug Something isn't working

Comments

@aborgna-q
Copy link
Collaborator

aborgna-q commented Feb 26, 2025 •
edited
Loading

There's uses of derive_more::{From, Error}, but the Cargo.toml only enables the display feature.

This is not caught by CI because other crates enable those features, and and those are additive in a workspace.

I found the error this semver checks.
@aborgna-q aborgna-q added the bug Something isn't working label Feb 26, 2025
@aborgna-q aborgna-q self-assigned this Feb 26, 2025
@aborgna-q aborgna-q mentioned this issue Feb 26, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2025
@aborgna-q
fix: Hugr-model using undeclared derive_more features (#1940)
7a9bda5 
Fixes #1939

The semver checks run still fail here because the `main` baseline still
has the error 💀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Hugr-model using undeclared derive_more features CQCL/hugr
1 participant
@aborgna-q