Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug, update documentation #364

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix bug, update documentation #364

merged 1 commit into from
Aug 8, 2024

Conversation

sildater
Copy link
Member

fixes the bug in the metrical strength features in note_features.py and adds documentation for the four attributes.

@sildater sildater added bug Something isn't working invalid This doesn't seem right labels Jul 25, 2024
@sildater sildater linked an issue Jul 25, 2024 that may be closed by this pull request
wrong values in metrical strength features #363
Closed
@sildater sildater requested a review from manoskary August 7, 2024 10:00
@huispaty huispaty requested review from huispaty and removed request for manoskary August 8, 2024 14:04
@huispaty huispaty merged commit 9d480d9 into develop Aug 8, 2024
3 checks passed
@sildater sildater mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huispaty huispaty huispaty approved these changes

Assignees
No one assigned
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong values in metrical strength features
2 participants
@sildater @huispaty